[-]: Promise API 계약 안정화#16
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
packages/main coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 사항
tutorial.open()replacement 경로를replacedreason 으로 고정하고closed는 외부 close 경로로 한정했습니다.tutorial.close()호출이 결과나onClose호출 횟수를 깨지 않도록 store guard를 보강했습니다.테스트 결과
pnpm -C packages/main testpnpm -C packages/main buildpnpm build남은 리스크
replacedreason 추가는 exhaustive switch 를 사용하는 TypeScript 소비자에게 후속 대응이 필요할 수 있습니다.tutorial.open()replacement 와 close 계열 경로 위주로 고정됐고, 향후 새 imperative API 가 추가되면 동일 계약을 다시 검토해야 합니다.